The intimate of writers, politicians and royalty, Benson confined his waspish anecdotes to journals kept over a period of 40 years, now available in a magnificent two-volume edition